Thread (58 messages) 58 messages, 3 authors, 2018-11-23

Re: [PATCH V11 14/19] block: handle non-cluster bio out of blk_bio_segment_split

From: Christoph Hellwig <hch@lst.de>
Date: 2018-11-22 10:40:49
Also in: dm-devel, linux-bcache, linux-block, linux-btrfs, linux-fsdevel, linux-mm, linux-raid, linux-xfs, lkml

On Thu, Nov 22, 2018 at 06:26:17PM +0800, Ming Lei wrote:
Suppose one bio includes (pg0, 0, 512) and (pg1, 512, 512):

The split is introduced by the following code in blk_bio_segment_split():

      if (bvprvp && bvec_gap_to_prev(q, bvprvp, bv.bv_offset))
		  	goto split;

Without this patch, for non-cluster, the two bvecs are just in different
segment, but still handled by one same bio. Now you convert into two bios.
Oh, true - we create new bios instead of new segments.  So I guess we
need to do something special here if we don't want to pay that overhead.

Or just look into killing the cluster setting..
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help