Thread (11 messages) 11 messages, 3 authors, 2018-02-12

Re: ext4 iomap SEEK broken [was: [GIT PULL] ext4 updates for 4.15]

From: Jiri Slaby <hidden>
Date: 2018-02-12 13:38:21
Also in: lkml

On 02/12/2018, 02:34 PM, Jiri Slaby wrote:
quoted hunk ↗ jump to hunk
@@ -3523,7 +3523,7 @@ static int ext4_iomap_begin(struct inode *inode,
loff_t offset, loff_t length,
                iomap->flags |= IOMAP_F_DIRTY;
        iomap->bdev = inode->i_sb->s_bdev;
        iomap->dax_dev = sbi->s_daxdev;
-       iomap->offset = first_block << blkbits;
+       iomap->offset = (u64)first_block << blkbits;
        iomap->length = (u64)map.m_len << blkbits;

        if (ret == 0) {

sounds about right?
Or even simpler:
-       iomap->offset = first_block << blkbits;
+       iomap->offset = offset;
quoted
regards,-- 
js
suse labs
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help