Re: [PATCH 2/3] Fix typos in code comments and developer docs.
From: Andreas Dilger <hidden>
Date: 2017-10-14 22:30:04
On Oct 14, 2017, at 12:44 PM, Sebastian Rasmussen [off-list ref] wrote:
Signed-off-by: Sebastian Rasmussen <redacted>
Did you use a tool to extract comments and then run this through a spell checker, or actually read all of the comments manually? Some of the errors are very hard to notice, even when already knowing the line has a correction. Some minor comments below. Reviewed-by: Andreas Dilger <redacted>
quoted hunk ↗ jump to hunk
diff --git a/lib/ext2fs/nt_io.c b/lib/ext2fs/nt_io.c index f0d16ae0..234f6b17 100644 --- a/lib/ext2fs/nt_io.c +++ b/lib/ext2fs/nt_io.c@@ -673,7 +673,7 @@ _NormalizeDeviceName(else if('f' == *Device) { // - // 3-d letted should be a digit. + // 3-d letter should be a digit.
This should probably be "3rd letter"?
quoted hunk ↗ jump to hunk
diff --git a/lib/ext2fs/res_gdt.c b/lib/ext2fs/res_gdt.c index eaa9cf87..45a475d9 100644 --- a/lib/ext2fs/res_gdt.c +++ b/lib/ext2fs/res_gdt.c@@ -104,7 +104,7 @@ errcode_t ext2fs_create_resize_inode(ext2_filsys fs)if (fs->blocksize == 1024 && sb_blk == 0) sb_blk = 1; - /* Maximum possible file size (we donly use the dindirect blocks) */ + /* Maximum possible file size (we only use the indirect blocks) */
The "donly" typo should be fixed, but "dindirect" is not a typo. This means "double indirect blocks". Maybe "(we only use double indirect blocks)" so that it still fits on a single line?
quoted hunk ↗ jump to hunk
#ifdef RES_GDT_DEBUGdiff --git a/lib/ext2fs/tdb.c b/lib/ext2fs/tdb.c index b36c4858..9c1dd31d 100644 --- a/lib/ext2fs/tdb.c +++ b/lib/ext2fs/tdb.c
Since the "tdb" code was copied from another project, you might consider to also submit these corrections to the original project.
quoted hunk ↗ jump to hunk
diff --git a/resize/resize2fs.c b/resize/resize2fs.c index 20a0c463..b53141a2 100644 --- a/resize/resize2fs.c +++ b/resize/resize2fs.c@@ -932,7 +932,7 @@ retry:/* * If we changed the number of block_group descriptor blocks, * we need to make sure they are all marked as reserved in the - * file systems's block allocation map. + * file systems' block allocation map.
This should probably be "filesystem's" since there is only one filesystem in question, and its block allocation map.
quoted hunk ↗ jump to hunk
diff --git a/util/gen-tarball.in b/util/gen-tarball.in index a3a02cef..6f087d1a 100644 --- a/util/gen-tarball.in +++ b/util/gen-tarball.in@@ -12,7 +12,7 @@ GZIP=gzip# # This hack is needed because texi2dvi blows up horribly if there are -# any '~' chracters in the directory pathname. So we kludge around it by +# any '~' characters in the directory path name. So we kludge around it by
IMHO, "pathname" is OK. Cheers, Andreas
Attachments
- signature.asc [application/pgp-signature] 195 bytes