Thread (5 messages) 5 messages, 2 authors, 2017-06-26

Re: [PATCH 1/3] vfs: Add page_cache_seek_hole_data helper

From: Christoph Hellwig <hch@infradead.org>
Date: 2017-06-26 10:41:57
Also in: linux-fsdevel, linux-xfs

On Fri, Jun 23, 2017 at 02:19:31AM +0200, Andreas Gruenbacher wrote:
Both ext4 and xfs implement seeking for the next hole or piece of data
in unwritten extents by scanning the page cache, and both versions share
the same bug when iterating the buffers of a page: the start offset into
the page isn't taken into account, so when a page fits more than two
filesystem blocks, things will go wrong.  For example, on a filesystem
with a block size of 1k, the following command will fail:

  xfs_io -f -c "falloc 0 4k" \
            -c "pwrite 1k 1k" \
            -c "pwrite 3k 1k" \
            -c "seek -a -r 0" foo
Can you wire this up for xfstests, please?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help