Re: [PATCH -v2] ext4: avoid unnecessary transaction stalls during writeback
From: Theodore Ts'o <tytso@mit.edu>
Date: 2017-05-02 14:18:09
From: Theodore Ts'o <tytso@mit.edu>
Date: 2017-05-02 14:18:09
On Tue, May 02, 2017 at 02:10:44PM +0200, Jan Kara wrote:
Yeah, thanks for finding the problem and fixing it up! The updated patch looks good. It is actually relatively easy to fix the original approach so that we don't have to allocate ioend unnecessarily (we just fetch the inode pointer on error through bio_vec->bv_page->mapping->host) but I'll do that separately on top of this change.
We'll need to be a little bit careful to make sure this works for the encryption case (where we use a temporary scratch/bounce buffer), but it should be possible to make that work (we just have to look at the right struct page). - Ted