Re: [PATCH] ext4: don't allow encrypted operations without keys
From: Eric Biggers <hidden>
Date: 2017-02-04 21:44:33
Also in:
linux-fsdevel
From: Eric Biggers <hidden>
Date: 2017-02-04 21:44:33
Also in:
linux-fsdevel
On Wed, Dec 28, 2016 at 12:22:52AM -0500, Theodore Ts'o wrote:
While we allow deletes without the key, the following should not be permitted: # cd /vdc/encrypted-dir-without-key # ls -l total 4 -rw-r--r-- 1 root root 0 Dec 27 22:35 6,LKNRJsp209FbXoSvJWzB -rw-r--r-- 1 root root 286 Dec 27 22:35 uRJ5vJh9gE7vcomYMqTAyD # mv uRJ5vJh9gE7vcomYMqTAyD 6,LKNRJsp209FbXoSvJWzB Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Hi Ted, this commit shows up twice in the ext4 tree, as 173b8439e1ba3 and a7ede371cb821, but the second actually adds the check two *more* times to ext4_cross_rename(), such that there are now a total of three checks in that function, all the same. Do you want to revert the second, unnecessary, commit? Thanks, Eric