Thread (4 messages) 4 messages, 2 authors, 2017-01-05

Re: [RFC PATCH] ext4: convert swap_inode_data() over to use swap() on most of the fields

From: Jan Kara <jack@suse.cz>
Date: 2017-01-05 07:25:39
Also in: lkml

On Wed 04-01-17 15:21:28, Jeff Layton wrote:
On Wed, 2017-01-04 at 16:43 +0100, Jan Kara wrote:
quoted
On Tue 20-12-16 10:55:41, Jeff Layton wrote:
quoted
For some odd reason, it forces a byte-by-byte copy of each field. A
plain old swap() on most of these fields would be more efficient. We
do need to retain one memswap however as that field is an array.

Signed-off-by: Jeff Layton <redacted>
Looks good to me. You can add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza
Thanks. Yeah, it's certainly nothing critical -- just something I
noticed while looking at the i_version rework. Seems like it might be
good to let soak in next for v4.11?
Yeah, it is definitely 4.11 material. I believe he'll pick up the patch to
his tree once he starts accumulating patches for the next merge window.

								Honza
-- 
Jan Kara [off-list ref]
SUSE Labs, CR
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help