Thread (16 messages) 16 messages, 3 authors, 2016-12-03

Re: [PATCH 3/5] mbcache: remove unnecessary module_get/module_put

From: Theodore Ts'o <tytso@mit.edu>
Date: 2016-12-03 20:41:56

On Sat, Nov 26, 2016 at 10:17:59PM -0800, Eric Biggers wrote:
When mbcache is built as a module, any modules that use it (ext2 and/or
ext4) will depend on its symbols directly, incrementing its reference
count.  Therefore, there is no need to do module_get/module_put.

Also note that since the module_get/module_put were in the mbcache
module itself, executing those lines of code was already dependent on
another reference to the mbcache module being held.

Signed-off-by: Eric Biggers <redacted>
Thanks, applied.

					- Ted
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help