Thread (2 messages) 2 messages, 2 authors, 2016-12-01

Re: [PATCH] ext4: disable pwsalt ioctl when encryption disabled by config

From: Theodore Ts'o <tytso@mit.edu>
Date: 2016-12-01 16:57:49

On Mon, Nov 21, 2016 at 04:23:12PM -0800, Eric Biggers wrote:
On a CONFIG_EXT4_FS_ENCRYPTION=n kernel, the ioctls to get and set
encryption policies were disabled but EXT4_IOC_GET_ENCRYPTION_PWSALT was
not.  But there's no good reason to expose the pwsalt ioctl if the
kernel doesn't support encryption.  The pwsalt ioctl was also disabled
pre-4.8 (via ext4_sb_has_crypto() previously returning 0 when encryption
was disabled by config) and seems to have been enabled by mistake when
ext4 encryption was refactored to use fs/crypto/.  So let's disable it
again.

Signed-off-by: Eric Biggers <redacted>
Thanks, applied.

					- Ted
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help