Re: [PATCH v4 05/12] dax: make 'wait_table' global variable static
From: Jan Kara <hidden>
Date: 2016-10-03 09:36:03
Also in:
linux-fsdevel, linux-mm, linux-xfs, lkml, nvdimm
On Thu 29-09-16 16:49:23, Ross Zwisler wrote:
The global 'wait_table' variable is only used within fs/dax.c, and generates the following sparse warning: fs/dax.c:39:19: warning: symbol 'wait_table' was not declared. Should it be static? Make it static so it has scope local to fs/dax.c, and to make sparse happy. Signed-off-by: Ross Zwisler <ross.zwisler-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Looks fine. You can add: Reviewed-by: Jan Kara <redacted> Honza
quoted hunk ↗ jump to hunk
--- fs/dax.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/fs/dax.c b/fs/dax.c index 9b9be8a..ac28cdf 100644 --- a/fs/dax.c +++ b/fs/dax.c@@ -52,7 +52,7 @@ #define DAX_WAIT_TABLE_BITS 12 #define DAX_WAIT_TABLE_ENTRIES (1 << DAX_WAIT_TABLE_BITS) -wait_queue_head_t wait_table[DAX_WAIT_TABLE_ENTRIES]; +static wait_queue_head_t wait_table[DAX_WAIT_TABLE_ENTRIES]; static int __init init_dax_wait_table(void) {-- 2.7.4
-- Jan Kara [off-list ref] SUSE Labs, CR