Thread (2 messages) 2 messages, 2 authors, 2016-09-22

Re: [PATCH] jbd2: Fix lockdep annotation in add_transaction_credits()

From: Theodore Ts'o <tytso@mit.edu>
Date: 2016-09-22 15:48:49

On Mon, Sep 19, 2016 at 02:30:43PM +0200, Jan Kara wrote:
Thomas has reported a lockdep splat hitting in
add_transaction_credits(). The problem is that that function calls
jbd2_might_wait_for_commit() while holding j_state_lock which is wrong
(we do not really wait for transaction commit while holding that lock).

Fix the problem by moving jbd2_might_wait_for_commit() into places where
we are ready to wait for transaction commit and thus j_state_lock is
unlocked.

Fixes: 1eaa566d368b214d99cbb973647c1b0b8102a9ae
Reported-by: Thomas Gleixner <redacted>
Signed-off-by: Jan Kara <jack@suse.cz>
Thanks, applied.

						- Ted
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help