Thread (4 messages) flat view 4 messages, 3 authors, 2016-09-10

Re: [PATCH] fscrypto: add authorization check for setting encryption policy

From: Theodore Ts'o <tytso@mit.edu>
Date: 2016-09-10 03:38:55
Also in: linux-fsdevel

On Thu, Sep 08, 2016 at 10:57:08AM -0700, Eric Biggers wrote:
On an ext4 or f2fs filesystem with file encryption supported, a user
could set an encryption policy on any empty directory(*) to which they
had readonly access.  This is obviously problematic, since such a
directory might be owned by another user and the new encryption policy
would prevent that other user from creating files in their own directory
(for example).

Fix this by requiring inode_owner_or_capable() permission to set an
encryption policy.  This means that either the caller must own the file,
or the caller must have the capability CAP_FOWNER.

(*) Or also on any regular file, for f2fs v4.6 and later and ext4
    v4.8-rc1 and later; a separate bug fix is coming for that.

Signed-off-by: Eric Biggers <redacted>
Cc: stable@vger.kernel.org # 4.1+; check fs/{ext4,f2fs}
Thanks, applied.  (Jaeguk, I plan to send this to Linus via the
ext4.git tree as a fix for v4.8)

					- Ted
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help