Re: [PATCH] ext4: add project quota mount options

On Fri, Jul 8, 2016 at 12:10 PM, Theodore Ts'o [off-list ref] wrote:

On Thu, Jul 07, 2016 at 11:06:10AM -0500, Eric Sandeen wrote:

quoted

quoted

add prjquota, prjjquota, offprjjquota mount options
for project quota.

These kind of mount options are used for old
quota design, and we can use quotas like these
way:

 # mkfs.ext4 /dev/sda
 # mount /dev/sda -o prjquota /mnt/test
 # quotacheck -p /mnt/test
 # quotaon /mnt/test

This new mount options are also useful to unify
some generic tests for xfs and ext4.

<...SNIP...>

Yes, for the sake of those poor, unfortunate souls who have to support
RHEL 6 (really, you couldn't pay me enough :-), it probably makes
sense to support the legacy style quota system using either the
usrquota/grpquota mount options, and so it makes sense for xfstests to
user the old-style aquota.user files that can be messed with by
confused userspace utilities, and which are dog-slow to check becuase
a separate quotacheck run is required.

But RHEL 6 doesn't have project quota, and so I don't see any reason
to try to support the legacy quota setup for project quota.  Yes, we
still want to test the quotatools VFS interfaces, and that means using
quotatools binaries --- but it doesn't follow from that choice that we
have to support the ancient ways of storing the quota files as
user-visible files, or using the ancient mount options which are just
horrible hacks to keep the old enterprise linux initscripts from
breaking.

Does this make sense?

I do agree with your point here, but the problem is as you can see come
from xfstests arguments from Dave Chinner.

I don't think currently users will try to old interface with project quota.
But as your request, i think you need some tests for project quota...

I think it make sense to add a test for lsattr/chattr interface for ext4,
whatever it can be moved to ext4 or generic.


Thanks,
Shilong

                                                        - Ted