Thread (2 messages) 2 messages, 2 authors, 2016-07-06

Re: [PATCH RESEND] e2fsck: update j_tail_sequence after recovery

From: Theodore Ts'o <tytso@mit.edu>
Date: 2016-07-06 03:11:18

On Wed, Jul 06, 2016 at 09:10:39AM +0900, Daeho Jeong wrote:
When journal is released, s_sequence is set to j_tail_sequence.
But, currently, even if the recovery process is successfully completed,
the j_tail_sequence and, finally, s_sequence are never changed. By this,
when we repeat doing power-off the device suddenly and executing e2fsck
without full scan before mount, the s_sequence number will never change
and, in a very rare case, newly generated journal logs will be
surprisingly grafted to the old journal logs. In this case, out-of-date
metadata log can be replayed on the filesystem area and the filesystem
can be crashed unintentionally by journal recovery process. Therefore,
we need to update j_tail_sequence after recovery process is successfully
completed in e2fsck.

Youngjin had repeated this test and found the problem. With our test,
the filesystem crash occurred within 4 hours.

Signed-off-by: Youngjin Gil <redacted>
Signed-off-by: Daeho Jeong <redacted>
Applied, thanks.

						 - Ted
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help