Thread (6 messages) flat view 6 messages, 3 authors, 2016-06-14

Re: [PATCH 02/21] fs: ext4: Use current_fs_time() for inode timestamps

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: 2016-06-09 18:45:03
Also in: linux-fsdevel, lkml

On Wed, Jun 8, 2016 at 10:04 PM, Deepa Dinamani [off-list ref] wrote:
CURRENT_TIME_SEC and CURRENT_TIME are not y2038 safe.
current_fs_time() will be transitioned to be y2038 safe
along with vfs.

current_fs_time() returns timestamps according to the
granularities set in the super_block.
All existing users and all the ones in this patch (and the others too,
although I didn't go through them very carefully) really would prefer
just passing in the inode directly, rather than the superblock.

So I don't want to add more users of this broken interface.  It was a
mistake to use the superblock. The fact that the time granularity
exists there is pretty much irrelevant. If every single user wants to
use an inode pointer, then that is what the function should get.

                 Linus
_______________________________________________
Y2038 mailing list
Y2038@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/y2038
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help