Re: [PATCH v18 18/22] richacl: xattr mapping functions

On Fri, Mar 11, 2016 at 3:17 PM, Christoph Hellwig [off-list ref] wrote:

quoted

+#include <linux/richacl_xattr.h>
+
+MODULE_LICENSE("GPL");

what's the point given that the code isn't even modolar?

A leftover, removed now.

quoted

+static void
+fix_xattr_from_user(const char *kname, void *kvalue, size_t size)
+{
+     if (strncmp(kname, XATTR_SYSTEM_PREFIX, XATTR_SYSTEM_PREFIX_LEN))
+             return;
+     kname += XATTR_SYSTEM_PREFIX_LEN;
+     if (!strcmp(kname, XATTR_POSIX_ACL_ACCESS) ||
+         !strcmp(kname, XATTR_POSIX_ACL_DEFAULT))
+             posix_acl_fix_xattr_from_user(kvalue, size);
+}

 /*
  * Extended attribute SET operations

@@ -329,9 +339,7 @@ setxattr(struct dentry *d, const char __user *name, const void __user *value,
                      error = -EFAULT;
                      goto out;
              }
-             if ((strcmp(kname, XATTR_NAME_POSIX_ACL_ACCESS) == 0) ||
-                 (strcmp(kname, XATTR_NAME_POSIX_ACL_DEFAULT) == 0))
-                     posix_acl_fix_xattr_from_user(kvalue, size);
+             fix_xattr_from_user(kname, kvalue, size);
      }

      error = vfs_setxattr(d, kname, kvalue, size, flags);

@@ -396,6 +404,17 @@ SYSCALL_DEFINE5(fsetxattr, int, fd, const char __user *, name,
      return error;
 }

+static void
+fix_xattr_to_user(const char *kname, void *kvalue, size_t size)
+{
+     if (strncmp(kname, XATTR_SYSTEM_PREFIX, XATTR_SYSTEM_PREFIX_LEN))
+             return;
+     kname += XATTR_SYSTEM_PREFIX_LEN;
+     if (!strcmp(kname, XATTR_POSIX_ACL_ACCESS) ||
+         !strcmp(kname, XATTR_POSIX_ACL_DEFAULT))
+             posix_acl_fix_xattr_to_user(kvalue, size);
+}
+
 /*
  * Extended attribute GET operations
  */

@@ -426,9 +445,7 @@ getxattr(struct dentry *d, const char __user *name, void __user *value,

      error = vfs_getxattr(d, kname, kvalue, size);
      if (error > 0) {
-             if ((strcmp(kname, XATTR_NAME_POSIX_ACL_ACCESS) == 0) ||
-                 (strcmp(kname, XATTR_NAME_POSIX_ACL_DEFAULT) == 0))
-                     posix_acl_fix_xattr_to_user(kvalue, size);
+             fix_xattr_to_user(kname, kvalue, size);

I don't see how this is related to the rest of the patch.

Indeed, this is unrelated now. I'll split it off.

quoted

+++ b/include/linux/richacl_xattr.h

What's the point in splitting this from the richacl.h header?

Same for the uapi versions.

quoted

+struct richacl_xattr {
+     unsigned char   a_version;
+     unsigned char   a_flags;

Explicit __u8 for uapi headers, please.

Okay.

Thanks,
Andreas