Thread (2 messages) 2 messages, 2 authors, 2016-01-03

Re: [PATCH] ext4: disable retry logic in ext4_set_encrypted_filename

From: Theodore Ts'o <tytso@mit.edu>
Date: 2016-01-03 04:50:16
Also in: lkml

On Sat, Jan 02, 2016 at 08:50:11PM +0100, Arnd Bergmann wrote:
gcc correctly warns that the ctx variable in ext4_set_encrypted_filename
has gone out of scope in ext4_set_encrypted_filename if we enter the
retry path and a 'goto' into the previous code block can not guarantee
to get the contents back:

fs/ext4/namei.c: In function 'ext4_set_encrypted_filename':
fs/ext4/namei.c:4035:10: warning: 'ctx' may be used uninitialized in this function [-Wmaybe-uninitialized]
   retval = ext4_xattr_set_handle(handle, inode,
Sorry, this was a known bug that I fixed about a week ago, but I
hadn't pushed out an update to the ext4 dev branch because I hadn't
had a chance to finish testing the project quota changes.  I've just
pushed out an update.

					- Ted
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help