Re: [patch] ext4: checking for NULL instead of IS_ERR
From: Jan Kara <jack@suse.cz>
Date: 2016-01-06 13:05:11
Also in:
kernel-janitors
On Wed 06-01-16 13:04:25, Dan Carpenter wrote:
The dqget() function returns error pointers on error, it doesn't return
NULL.
Fixes: 76481d7a60a4 ('ext4: add project quota support')
Signed-off-by: Dan Carpenter <redacted>Correct. You can add: Reviewed-by: Jan Kara <jack@suse.cz> Honza
quoted hunk ↗ jump to hunk
diff --git a/fs/ext4/super.c b/fs/ext4/super.c index 50b2207..103a7a3 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c@@ -4844,8 +4844,8 @@ static int ext4_statfs_project(struct super_block *sb, qid = make_kqid_projid(projid); dquot = dqget(sb, qid); - if (!dquot) - return -ESRCH; + if (IS_ERR(dquot)) + return PTR_ERR(dquot); spin_lock(&dq_data_lock); limit = (dquot->dq_dqb.dqb_bsoftlimit ? --To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
-- Jan Kara [off-list ref] SUSE Labs, CR