Thread (54 messages) 54 messages, 8 authors, 2016-01-10

Re: [PATCH 01/35] block/fs/drivers: remove rw argument from submit_bio

From: Mike Christie <hidden>
Date: 2016-01-10 00:43:32
Also in: dm-devel, linux-bcache, linux-btrfs, linux-f2fs-devel, linux-fsdevel, linux-raid, linux-scsi, linux-xfs, lkml, ocfs2-devel

On 01/09/2016 07:34 AM, Christoph Hellwig wrote:
quoted
 				count);
quoted
diff --git a/block/blk-flush.c b/block/blk-flush.c
index 9c423e5..e092e13 100644
--- a/block/blk-flush.c
+++ b/block/blk-flush.c
@@ -484,8 +484,9 @@ int blkdev_issue_flush(struct block_device *bdev, gfp_t gfp_mask,
 
 	bio = bio_alloc(gfp_mask, 0);
 	bio->bi_bdev = bdev;
+	bio->bi_rw |= WRITE_FLUSH;
Shouldn't the |= be a = here and in many other places?
Yeah, I was trying to merge bi_rw and bio_flags. I am not going to send
that. I will fix up the patchset.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help