Re: [PATCH v14 04/22] vfs: Make the inode passed to inode_change_ok non-const
From: Andreas Dilger <hidden>
Date: 2015-11-06 21:04:07
Also in:
linux-api, linux-cifs, linux-fsdevel, linux-nfs, linux-xfs, lkml
Possibly related (same subject, not in this thread)
- 2015-11-05 · [PATCH v14 04/22] vfs: Make the inode passed to inode_change_ok non-const · Andreas Gruenbacher <agruenba@redhat.com>
On Nov 5, 2015, at 4:39 AM, Andreas Gruenbacher [off-list ref] wrote: We will need to call iop->permission and iop->get_acl from inode_change_ok() for additional permission checks, and both take a non-const inode.
Seems unfortunate that those functions cannot themselves be changed to take a const struct inode, but it doesn't look possible. Reviewed-by: Andreas Dilger <redacted>
quoted hunk
Signed-off-by: Andreas Gruenbacher <redacted> Reviewed-by: J. Bruce Fields <redacted> --- fs/attr.c | 2 +- include/linux/fs.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)diff --git a/fs/attr.c b/fs/attr.c index 6530ced..328be71 100644 --- a/fs/attr.c +++ b/fs/attr.c@@ -28,7 +28,7 @@ * Should be called as the first thing in ->setattr implementations, * possibly after taking additional locks. */ -int inode_change_ok(const struct inode *inode, struct iattr *attr) +int inode_change_ok(struct inode *inode, struct iattr *attr){ unsigned int ia_valid = attr->ia_valid;diff --git a/include/linux/fs.h b/include/linux/fs.h index 402acd7..aab32c8 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h@@ -2871,7 +2871,7 @@ extern int buffer_migrate_page(struct address_space *,#define buffer_migrate_page NULL #endif -extern int inode_change_ok(const struct inode *, struct iattr *); +extern int inode_change_ok(struct inode *, struct iattr *); extern int inode_newsize_ok(const struct inode *, loff_t offset); extern void setattr_copy(struct inode *inode, const struct iattr *attr); -- 2.5.0
Cheers, Andreas
Attachments
- signature.asc [application/pgp-signature] 833 bytes