Thread (43 messages) 43 messages, 2 authors, 2015-10-16
STALE3884d
Revisions (3)
  1. v11 current
  2. v12 [diff vs current]
  3. v13 [diff vs current]

[PATCH v11 41/48] xfs: Don't allow unmapped identifiers in richacls

From: Andreas Gruenbacher <agruenba@redhat.com>
Date: 2015-10-16 15:18:19
Also in: linux-api, linux-cifs, linux-fsdevel, linux-nfs, linux-xfs, lkml
Subsystem: filesystems (vfs and infrastructure), the rest, xfs filesystem · Maintainers: Alexander Viro, Christian Brauner, Linus Torvalds, Carlos Maiolino

Don't allow acls which contain unmapped identifiers: they are meaningful
for remote file systems only.

Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
---
 fs/xfs/xfs_richacl.c | 4 ++++
 1 file changed, 4 insertions(+)
diff --git a/fs/xfs/xfs_richacl.c b/fs/xfs/xfs_richacl.c
index 73c2d24..4f938b7 100644
--- a/fs/xfs/xfs_richacl.c
+++ b/fs/xfs/xfs_richacl.c
@@ -77,6 +77,10 @@ xfs_set_richacl(struct inode *inode, struct richacl *acl)
 	if (!acl)
 		return xfs_remove_richacl(inode);
 
+	/* Don't allow acls with unmapped identifiers. */
+	if (richacl_has_unmapped_identifiers(acl))
+		return -EINVAL;
+
 	if (richacl_equiv_mode(acl, &mode) == 0) {
 		xfs_set_mode(inode, mode);
 		return xfs_remove_richacl(inode);
-- 
2.5.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help