Re: [PATCH -resend] jbd2: revert must-not-fail allocation loops back to GFP_NOFAIL
flat view
From: Theodore Ts'o <tytso@mit.edu>
Date: 2015-06-08 14:54:32
Also in:
linux-fsdevel, linux-mm, lkml
On Mon, Jun 08, 2015 at 03:28:44PM +0200, Michal Hocko wrote:
This basically reverts 47def82672b3 (jbd2: Remove __GFP_NOFAIL from jbd2 layer). The deprecation of __GFP_NOFAIL was a bad choice because it led to open coding the endless loop around the allocator rather than removing the dependency on the non failing allocation. So the deprecation was a clear failure and the reality tells us that __GFP_NOFAIL is not even close to go away. It is still true that __GFP_NOFAIL allocations are generally discouraged and new uses should be evaluated and an alternative (pre-allocations or reservations) should be considered but it doesn't make any sense to lie the allocator about the requirements. Allocator can take steps to help making a progress if it knows the requirements. Signed-off-by: Michal Hocko <redacted> Acked-by: David Rientjes <rientjes@google.com>
Applied, thanks. - Ted -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>