Thread (6 messages) 6 messages, 2 authors, 2015-01-25

Re: [PATCH-v7 1/3] vfs: add support for a lazytime mount option

From: Theodore Ts'o <tytso@mit.edu>
Date: 2015-01-25 03:03:53
Also in: linux-fsdevel

On Mon, Jan 19, 2015 at 06:21:31PM +0400, Dmitry Monakhov wrote:
quoted
+	if (flags & I_DIRTY_INODE)
+		flags &= ~I_DIRTY_TIME;
+	dirtytime = flags & I_DIRTY_TIME;
TYPO? 'dirtytime' is always false because you have already cleared that bit.
Probably you want to do that: 
        dirtytime = flags & I_DIRTY_TIME;
	if (flags & I_DIRTY_INODE)
		flags &= ~I_DIRTY_TIME;
Nice catch; I screwed that up in the -v7 version of the patch.  I've
fixed it in the -v8 version that I just sent out.

      	    	    	    	   	- Ted
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help