Re: [PATCHv4 0/3] new APIs to allocate buffer-cache with user specific flag
From: Andrew Morton <akpm@linux-foundation.org>
Date: 2014-09-04 22:16:12
Also in:
linux-fsdevel, lkml
On Thu, 4 Sep 2014 16:29:38 +0900 Gioh Kim [off-list ref] wrote:
This patch try to solve problem that a long-lasting page caches of ext4 superblock and journaling of superblock disturb page migration. I've been testing CMA feature on my ARM-based platform and found that two page caches cannot be migrated. They are page caches of superblock of ext4 filesystem and its journaling data. Current ext4 reads superblock with sb_bread() that allocates page from movable area. But the problem is that ext4 hold the page until it is unmounted. If root filesystem is ext4 the page cannot be migrated forever. And also the journaling data for the superblock cannot be migreated. I introduce new APIs that allocates page cache with specific flag passed by an argument. *_gfp APIs are for user want to set page allocation flag for page cache allocation. And *_unmovable APIs are for the user wants to allocate page cache from non-movable area. It is useful for ext4/ext3 and others that want to hold page cache for a long time.
Could we please have some detailed information about the real-world effect of this patchset? You earlier said "My test platform is currently selling item in the market. And also I test my patch when my platform is working as if real user uses it.". But what were the problems which were observed in standard kernels and what effect did this patchset have upon them? Some quantitative measurements will really help here. I'm trying to get an understanding of how effective and important the change is, whether others will see similar benefits. I'd also like to understand how *complete* the fix is - were the problems which you observed completely fixed, or do outstanding problems remain? Thanks.