[PATCH] ext4: use mkfs.ext4 -F instead of piping in yes
From: Theodore Ts'o <tytso@mit.edu>
Date: 2014-09-07 12:29:21
Also in:
fstests
Subsystem:
the rest · Maintainer:
Linus Torvalds
Using "yes | mkfs.ext4 ..." results in the error message results in
the test failing, at least for some versions of e2fsprogs:
+yes: standard output: Broken pipe
+yes: write error
It better to use the -F option, which will eliminate the questions.
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: Xiaoguang Wang <redacted>
Cc: Eryu Guan <redacted>
---
tests/ext4/003 | 2 +-
tests/ext4/306 | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/ext4/003 b/tests/ext4/003
index 572e685..a2e9d75 100755
--- a/tests/ext4/003
+++ b/tests/ext4/003@@ -43,7 +43,7 @@ _require_ext4_bigalloc rm -f $seqres.full -yes | mkfs.ext4 -O bigalloc -C 65536 -g 256 $SCRATCH_DEV 512m \ +mkfs.ext4 -F -O bigalloc -C 65536 -g 256 $SCRATCH_DEV 512m \ >> $seqres.full 2>&1 _scratch_mount || _fail "couldn't mount fs"
diff --git a/tests/ext4/306 b/tests/ext4/306
index fd50b0e..fd5c3a2 100755
--- a/tests/ext4/306
+++ b/tests/ext4/306@@ -48,7 +48,7 @@ _require_scratch rm -f $seqres.full # Make a small ext4 fs with extents disabled & mount it -yes | mkfs.ext4 -O ^extents,^64bit $SCRATCH_DEV 512m >> $seqres.full 2>&1 +mkfs.ext4 -F -O ^extents,^64bit $SCRATCH_DEV 512m >> $seqres.full 2>&1 _scratch_mount || _fail "couldn't mount fs" # Create a small non-extent-based file
--
2.1.0