Re: [PATCHv3 3/3] jbd/jbd2: allocate buffer-cache for superblock inode in non-movable area
From: Jan Kara <jack@suse.cz>
Date: 2014-08-28 10:07:06
Also in:
linux-fsdevel, lkml
On Thu 28-08-14 11:33:20, Gioh Kim wrote:
A long-lasting buffer-cache can distrub page migration so that it must be allocated from non-movable area. The journal_init_inode is creating a buffer-cache for superblock journaling. The superblock exists until system shutdown so that the buffer-cache for the superblock would also exist for a long time and it can distrub page migration. This patch make the buffer-cache be allocated from non-movable area not to distrub page migration.
The patch looks good. You can add: Reviewed-by: Jan Kara <jack@suse.cz> Honza
quoted hunk ↗ jump to hunk
Signed-off-by: Gioh Kim <redacted> --- fs/jbd/journal.c | 2 +- fs/jbd2/journal.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)diff --git a/fs/jbd/journal.c b/fs/jbd/journal.c index 06fe11e..aab8549 100644 --- a/fs/jbd/journal.c +++ b/fs/jbd/journal.c@@ -886,7 +886,7 @@ journal_t * journal_init_inode (struct inode *inode) goto out_err; } - bh = __getblk(journal->j_dev, blocknr, journal->j_blocksize); + bh = getblk_unmovable(journal->j_dev, blocknr, journal->j_blocksize); if (!bh) { printk(KERN_ERR "%s: Cannot get buffer for journal superblock\n",diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c index 67b8e30..65bd3b1 100644 --- a/fs/jbd2/journal.c +++ b/fs/jbd2/journal.c@@ -1237,7 +1237,7 @@ journal_t * jbd2_journal_init_inode (struct inode *inode) goto out_err; } - bh = __getblk(journal->j_dev, blocknr, journal->j_blocksize); + bh = getblk_unmovable(journal->j_dev, blocknr, journal->j_blocksize); if (!bh) { printk(KERN_ERR "%s: Cannot get buffer for journal superblock\n", --1.7.9.5
-- Jan Kara [off-list ref] SUSE Labs, CR