Re: [PATCH] tune2fs: fix uninitialized variable in remove_journal_device
From: Theodore Ts'o <tytso@mit.edu>
Date: 2014-08-02 01:32:12
On Fri, Aug 01, 2014 at 08:38:30AM +0200, Andreas Dilger wrote:
quoted
/* Write back the journal superblock */ - if ((retval = io_channel_write_blk64(jfs->io, start, - -SUPERBLOCK_SIZE, buf))) { + if ((retval = io_channel_write_blk64(jfs->io, + ext2fs_journal_sb_start(fs->blocksize), + -SUPERBLOCK_SIZE, buf))) {Better to also remove assignment in conditional check.
Good point, done. - Ted