Re: [PATCH 11/49] e2fsck: zero errcode when checking inline data blocks

[PATCH 00/49] e2fsprogs patchbomb 3/14 · Darrick J. Wong <hidden> · 2014-03-11
[PATCH 01/49] create_inode: clean up return mess in do_write_internal · Darrick J. Wong <hidden> · 2014-03-11
Re: [PATCH 01/49] create_inode: clean up return mess in do_write_internal · Andreas Dilger <hidden> · 2014-03-11
Re: [PATCH 01/49] create_inode: clean up return mess in do_write_internal · Darrick J. Wong <hidden> · 2014-03-11
Re: [PATCH 01/49] create_inode: clean up return mess in do_write_internal · Theodore Ts'o <tytso@mit.edu> · 2014-03-11
Re: [PATCH 01/49] create_inode: clean up return mess in do_write_internal · Theodore Ts'o <tytso@mit.edu> · 2014-03-12
[PATCH 02/49] create_inode: minor cleanups · Darrick J. Wong <hidden> · 2014-03-11
Re: [PATCH 02/49] create_inode: minor cleanups · Andreas Dilger <hidden> · 2014-03-11
Re: [PATCH 02/49] create_inode: minor cleanups · Theodore Ts'o <tytso@mit.edu> · 2014-03-12
Re: [PATCH 02/49] create_inode: minor cleanups · Theodore Ts'o <tytso@mit.edu> · 2014-03-12
[PATCH 03/49] create_inode: whitespace fixes · Darrick J. Wong <hidden> · 2014-03-11
Re: [PATCH 03/49] create_inode: whitespace fixes · Theodore Ts'o <tytso@mit.edu> · 2014-03-12
[PATCH 04/49] create_inode: move debugfs internal state back to debugfs · Darrick J. Wong <hidden> · 2014-03-11
Re: [PATCH 04/49] create_inode: move debugfs internal state back to debugfs · Theodore Ts'o <tytso@mit.edu> · 2014-03-12
[PATCH 05/49] create_inode: handle hard link inum mappings per populate_fs invocation · Darrick J. Wong <hidden> · 2014-03-11
Re: [PATCH 05/49] create_inode: handle hard link inum mappings per populate_fs invocation · Theodore Ts'o <tytso@mit.edu> · 2014-03-12
[PATCH 06/49] libext2fs: support modifying arbitrary extended attributes (v5) · Darrick J. Wong <hidden> · 2014-03-11
Re: [PATCH 06/49] libext2fs: support modifying arbitrary extended attributes (v5) · Theodore Ts'o <tytso@mit.edu> · 2014-03-12
[PATCH 07/49] debugfs: create commands to edit extended attributes · Darrick J. Wong <hidden> · 2014-03-11
Re: [PATCH 07/49] debugfs: create commands to edit extended attributes · Theodore Ts'o <tytso@mit.edu> · 2014-03-12
[PATCH 08/49] e2fsck: don't rehash inline directories · Darrick J. Wong <hidden> · 2014-03-11
Re: [PATCH 08/49] e2fsck: don't rehash inline directories · Theodore Ts'o <tytso@mit.edu> · 2014-03-13
Re: [PATCH 08/49] e2fsck: don't rehash inline directories · Darrick J. Wong <hidden> · 2014-03-13
Re: [PATCH 08/49] e2fsck: don't rehash inline directories · Theodore Ts'o <tytso@mit.edu> · 2014-03-13
[PATCH 09/49] libext2fs: don't fail when doing a strict rewrite of inline data · Darrick J. Wong <hidden> · 2014-03-11
Re: [PATCH 09/49] libext2fs: don't fail when doing a strict rewrite of inline data · Theodore Ts'o <tytso@mit.edu> · 2014-03-14
[PATCH 10/49] libext2fs: fix iblocks correctly when expanding an inline_data file · Darrick J. Wong <hidden> · 2014-03-11
Re: [PATCH 10/49] libext2fs: fix iblocks correctly when expanding an inline_data file · Andreas Dilger <hidden> · 2014-03-12
Re: [PATCH 10/49] libext2fs: fix iblocks correctly when expanding an inline_data file · Darrick J. Wong <hidden> · 2014-03-12
Re: [PATCH 10/49] libext2fs: fix iblocks correctly when expanding an inline_data file · Theodore Ts'o <tytso@mit.edu> · 2014-03-14
[PATCH 11/49] e2fsck: zero errcode when checking inline data blocks · Darrick J. Wong <hidden> · 2014-03-11
Re: [PATCH 11/49] e2fsck: zero errcode when checking inline data blocks · Theodore Ts'o <tytso@mit.edu> · 2014-03-14
[PATCH 12/49] libext2fs: during inlinedata expand, don't corrupt inode · Darrick J. Wong <hidden> · 2014-03-11
Re: [PATCH 12/49] libext2fs: during inlinedata expand, don't corrupt inode · Theodore Ts'o <tytso@mit.edu> · 2014-03-14
[PATCH 13/49] libext2fs: repair side effects when iterating dirents in inline dirs · Darrick J. Wong <hidden> · 2014-03-11
Re: [PATCH 13/49] libext2fs: repair side effects when iterating dirents in inline dirs · Theodore Ts'o <tytso@mit.edu> · 2014-03-14
[PATCH 14/49] resize2fs: add inline dirs for remapping · Darrick J. Wong <hidden> · 2014-03-11
Re: [PATCH 14/49] resize2fs: add inline dirs for remapping · Theodore Ts'o <tytso@mit.edu> · 2014-03-14
[PATCH 15/49] all: Introduce cppcheck static checking for make C=1 · Darrick J. Wong <hidden> · 2014-03-11
Re: [PATCH 15/49] all: Introduce cppcheck static checking for make C=1 · Theodore Ts'o <tytso@mit.edu> · 2014-03-14
[PATCH 16/49] misc: cppcheck cleanups · Darrick J. Wong <hidden> · 2014-03-11
Re: [PATCH 16/49] misc: cppcheck cleanups · Theodore Ts'o <tytso@mit.edu> · 2014-03-14
[PATCH 17/49] libext2fs: fix 64bit overflow in ext2fs_block_alloc_stats_range · Darrick J. Wong <hidden> · 2014-03-11
Re: [PATCH 17/49] libext2fs: fix 64bit overflow in ext2fs_block_alloc_stats_range · Theodore Ts'o <tytso@mit.edu> · 2014-03-14
[PATCH 18/49] misc: fix header complaints and resource leaks in e2fsprogs · Darrick J. Wong <hidden> · 2014-03-11
Re: [PATCH 18/49] misc: fix header complaints and resource leaks in e2fsprogs · Theodore Ts'o <tytso@mit.edu> · 2014-03-14
Re: [PATCH 18/49] misc: fix header complaints and resource leaks in e2fsprogs · Theodore Ts'o <tytso@mit.edu> · 2014-03-14
Re: [PATCH 18/49] misc: fix header complaints and resource leaks in e2fsprogs · Darrick J. Wong <hidden> · 2014-03-14
[PATCH 19/49] libext2fs: fix memory leak when drastically shrinking extent tree depth · Darrick J. Wong <hidden> · 2014-03-11
Re: [PATCH 19/49] libext2fs: fix memory leak when drastically shrinking extent tree depth · Theodore Ts'o <tytso@mit.edu> · 2014-03-14
[PATCH 20/49] libext2fs: fix parents when modifying extents · Darrick J. Wong <hidden> · 2014-03-11
Re: [PATCH 20/49] libext2fs: fix parents when modifying extents · Theodore Ts'o <tytso@mit.edu> · 2014-03-14
Re: [PATCH 20/49] libext2fs: fix parents when modifying extents · Darrick J. Wong <hidden> · 2014-03-14
Re: [PATCH 20/49] libext2fs: fix parents when modifying extents · Theodore Ts'o <tytso@mit.edu> · 2014-03-15
Re: [PATCH 20/49] libext2fs: fix parents when modifying extents · Darrick J. Wong <hidden> · 2014-03-17
[PATCH 21/49] e2fsck: print runs of duplicate blocks instead of all of them · Darrick J. Wong <hidden> · 2014-03-11
Re: [PATCH 21/49] e2fsck: print runs of duplicate blocks instead of all of them · Theodore Ts'o <tytso@mit.edu> · 2014-03-15
[PATCH 22/49] e2fsck: verify checksums after checking everything else · Darrick J. Wong <hidden> · 2014-03-11
[PATCH 23/49] e2fsck: fix the extended attribute checksum error message · Darrick J. Wong <hidden> · 2014-03-11
[PATCH 24/49] e2fsck: insert a missing dirent tail for checksums if possible · Darrick J. Wong <hidden> · 2014-03-11
[PATCH 25/49] e2fsck: write dir blocks after new inode when reconstructing root/lost+found · Darrick J. Wong <hidden> · 2014-03-11
[PATCH 26/49] tests: add test for corrupted checksummed root directory block · Darrick J. Wong <hidden> · 2014-03-11
[PATCH 27/49] dumpe2fs: add switch to disable checksum verification · Darrick J. Wong <hidden> · 2014-03-11
[PATCH 29/49] libext2fs: support allocating uninit blocks in bmap2() · Darrick J. Wong <hidden> · 2014-03-11
[PATCH 28/49] mke2fs: set block_validity as a default mount option · Darrick J. Wong <hidden> · 2014-03-11
[PATCH 30/49] libext2fs: file IO routines should handle uninit blocks · Darrick J. Wong <hidden> · 2014-03-11
[PATCH 31/49] resize2fs: convert fs to and from 64bit mode · Darrick J. Wong <hidden> · 2014-03-11
[PATCH 32/49] resize2fs: when toggling 64bit, don't free in-use bg data clusters · Darrick J. Wong <hidden> · 2014-03-11
[PATCH 33/49] resize2fs: adjust reserved_gdt_blocks when changing group descriptor size · Darrick J. Wong <hidden> · 2014-03-11
[PATCH 34/49] libext2fs: have UNIX IO manager use pread/pwrite · Darrick J. Wong <hidden> · 2014-03-11
[PATCH 35/49] ext2fs: add readahead method to improve scanning · Darrick J. Wong <hidden> · 2014-03-11
Re: [PATCH 35/49] ext2fs: add readahead method to improve scanning · Andreas Dilger <hidden> · 2014-03-17
[PATCH 36/49] libext2fs: allow clients to read-ahead metadata · Darrick J. Wong <hidden> · 2014-03-11
Re: [PATCH 36/49] libext2fs: allow clients to read-ahead metadata · Andreas Dilger <hidden> · 2014-03-17
[PATCH 37/49] e2fsck: read-ahead metadata during passes 1, 2, and 4 · Darrick J. Wong <hidden> · 2014-03-11
Re: [PATCH 37/49] e2fsck: read-ahead metadata during passes 1, 2, and 4 · Andreas Dilger <hidden> · 2014-03-17
Re: [PATCH 37/49] e2fsck: read-ahead metadata during passes 1, 2, and 4 · Darrick J. Wong <hidden> · 2014-03-18
Re: [PATCH 37/49] e2fsck: read-ahead metadata during passes 1, 2, and 4 · Darrick J. Wong <hidden> · 2014-03-18
[PATCH 38/49] libext2fs: when appending to a file, don't split an index block in equal halves · Darrick J. Wong <hidden> · 2014-03-11
[PATCH 39/49] libext2fs: find inode goal when allocating blocks · Darrick J. Wong <hidden> · 2014-03-11
[PATCH 40/49] libext2fs: find a range of empty blocks · Darrick J. Wong <hidden> · 2014-03-11
[PATCH 41/49] libext2fs: provide a function to set inode size · Darrick J. Wong <hidden> · 2014-03-11
[PATCH 42/49] libext2fs: implement fallocate · Darrick J. Wong <hidden> · 2014-03-11
[PATCH 44/49] fuse2fs: translate ACL structures · Darrick J. Wong <hidden> · 2014-03-11
[PATCH 45/49] fuse2fs: handle 64-bit dates correctly · Darrick J. Wong <hidden> · 2014-03-11
[PATCH 46/49] fuse2fs: implement fallocate · Darrick J. Wong <hidden> · 2014-03-11
[PATCH 48/49] tests: enable using fuse2fs with metadata checksum test · Darrick J. Wong <hidden> · 2014-03-11
[PATCH 49/49] tests: test date handling · Darrick J. Wong <hidden> · 2014-03-11

From: Theodore Ts'o <tytso@mit.edu>
Date: 2014-03-14 13:27:00

On Mon, Mar 10, 2014 at 11:55:08PM -0700, Darrick J. Wong wrote:

When checking inline data blocks, always zero pctx->errcode because
otherwise a previous error condition could leak through and "cause" a
fatal block iteration failure.  I found this by corrupting an xattr
block on an inline_data inode and fsck aborted when I tried to repair
it.

Signed-off-by: Darrick J. Wong <redacted>

Thanks, applied.

					- Ted

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help