Re: [PATCH 12/74] libext2fs: make symlinks safe for 64bit blocks and extents

[PATCH v3 00/74] e2fsprogs patchbomb 12/2013 · Darrick J. Wong <hidden> · 2013-12-11
[PATCH 01/74] libext2fs: don't overflow when punching indirect blocks with large blocks · Darrick J. Wong <hidden> · 2013-12-11
Re: [PATCH 01/74] libext2fs: don't overflow when punching indirect blocks with large blocks · Theodore Ts'o <tytso@mit.edu> · 2013-12-12
[PATCH 02/74] libext2fs: fix tests that set LARGE_FILE · Darrick J. Wong <hidden> · 2013-12-11
Re: [PATCH 02/74] libext2fs: fix tests that set LARGE_FILE · Theodore Ts'o <tytso@mit.edu> · 2013-12-12
[PATCH 03/74] mke2fs: load configfile blocksize setting before 64bit checks · Darrick J. Wong <hidden> · 2013-12-11
Re: [PATCH 03/74] mke2fs: load configfile blocksize setting before 64bit checks · Theodore Ts'o <tytso@mit.edu> · 2013-12-12
Re: [PATCH 03/74] mke2fs: load configfile blocksize setting before 64bit checks · Andreas Dilger <hidden> · 2013-12-12
Re: [PATCH 03/74] mke2fs: load configfile blocksize setting before 64bit checks · Darrick J. Wong <hidden> · 2013-12-12
[PATCH] mke2fs: clean up kernel version tests · Darrick J. Wong <hidden> · 2013-12-12
[PATCH 04/74] libext2fs: use ext2fs_punch() to truncate quota file · Darrick J. Wong <hidden> · 2013-12-11
Re: [PATCH 04/74] libext2fs: use ext2fs_punch() to truncate quota file · Theodore Ts'o <tytso@mit.edu> · 2013-12-12
Re: [PATCH 04/74] libext2fs: use ext2fs_punch() to truncate quota file · Theodore Ts'o <tytso@mit.edu> · 2013-12-12
Re: [PATCH 04/74] libext2fs: use ext2fs_punch() to truncate quota file · Darrick J. Wong <hidden> · 2013-12-12
Re: [PATCH 04/74] libext2fs: use ext2fs_punch() to truncate quota file · Theodore Ts'o <tytso@mit.edu> · 2013-12-12
Re: [PATCH 04/74] libext2fs: use ext2fs_punch() to truncate quota file · Darrick J. Wong <hidden> · 2013-12-12
[PATCH 05/74] debugfs: fix init_filesys help text · Darrick J. Wong <hidden> · 2013-12-11
Re: [PATCH 05/74] debugfs: fix init_filesys help text · Theodore Ts'o <tytso@mit.edu> · 2013-12-12
[PATCH 06/74] tune2fs: forbid changing uuid on an uninit_bg filesystem · Darrick J. Wong <hidden> · 2013-12-11
Re: [PATCH 06/74] tune2fs: forbid changing uuid on an uninit_bg filesystem · Theodore Ts'o <tytso@mit.edu> · 2013-12-15
[PATCH 07/74] libext2fs: tweak inline data error wording · Darrick J. Wong <hidden> · 2013-12-11
Re: [PATCH 07/74] libext2fs: tweak inline data error wording · Theodore Ts'o <tytso@mit.edu> · 2013-12-13
[PATCH 08/74] libext2fs: don't allow ridiculously large logical block numbers · Darrick J. Wong <hidden> · 2013-12-11
Re: [PATCH 08/74] libext2fs: don't allow ridiculously large logical block numbers · Theodore Ts'o <tytso@mit.edu> · 2013-12-12
[PATCH 09/74] libext2fs: fix another minor grammatical error in the error catalog · Darrick J. Wong <hidden> · 2013-12-11
Re: [PATCH 09/74] libext2fs: fix another minor grammatical error in the error catalog · Theodore Ts'o <tytso@mit.edu> · 2013-12-12
[PATCH 10/74] debugfs: fix various minor bogosity · Darrick J. Wong <hidden> · 2013-12-11
Re: [PATCH 10/74] debugfs: fix various minor bogosity · Theodore Ts'o <tytso@mit.edu> · 2013-12-12
[PATCH 11/74] misc: use the checksum predicate function, not raw flag tests · Darrick J. Wong <hidden> · 2013-12-11
Re: [PATCH 11/74] misc: use the checksum predicate function, not raw flag tests · Theodore Ts'o <tytso@mit.edu> · 2013-12-13
[PATCH 12/74] libext2fs: make symlinks safe for 64bit blocks and extents · Darrick J. Wong <hidden> · 2013-12-11
Re: [PATCH 12/74] libext2fs: make symlinks safe for 64bit blocks and extents · Theodore Ts'o <tytso@mit.edu> · 2013-12-12
[PATCH 13/74] debugfs: handle 64bit block numbers · Darrick J. Wong <hidden> · 2013-12-11
Re: [PATCH 13/74] debugfs: handle 64bit block numbers · Theodore Ts'o <tytso@mit.edu> · 2013-12-12
Re: [PATCH 13/74] debugfs: handle 64bit block numbers · Eric Sandeen <hidden> · 2013-12-17
[PATCH 14/74] libext2fs: fileio should use 64bit io routines · Darrick J. Wong <hidden> · 2013-12-11
Re: [PATCH 14/74] libext2fs: fileio should use 64bit io routines · Theodore Ts'o <tytso@mit.edu> · 2013-12-12
[PATCH 15/74] resize2fs: rewrite extent/dir/ea block checksums when migrating · Darrick J. Wong <hidden> · 2013-12-11
Re: [PATCH 15/74] resize2fs: rewrite extent/dir/ea block checksums when migrating · Theodore Ts'o <tytso@mit.edu> · 2013-12-13
[PATCH 16/74] debugfs: don't leak fd when calling dump_file · Darrick J. Wong <hidden> · 2013-12-11
Re: [PATCH 16/74] debugfs: don't leak fd when calling dump_file · Theodore Ts'o <tytso@mit.edu> · 2013-12-12
[PATCH 17/74] debugfs: don't leak mmp_s memory · Darrick J. Wong <hidden> · 2013-12-11
Re: [PATCH 17/74] debugfs: don't leak mmp_s memory · Theodore Ts'o <tytso@mit.edu> · 2013-12-12
Re: [PATCH 17/74] debugfs: don't leak mmp_s memory · Andreas Dilger <hidden> · 2013-12-12
Re: [PATCH 17/74] debugfs: don't leak mmp_s memory · Darrick J. Wong <hidden> · 2013-12-12
[PATCH 18/74] e2fsck: fix memory leaks · Darrick J. Wong <hidden> · 2013-12-11
Re: [PATCH 18/74] e2fsck: fix memory leaks · Theodore Ts'o <tytso@mit.edu> · 2013-12-12
Re: [PATCH 18/74] e2fsck: fix memory leaks · Eric Sandeen <hidden> · 2013-12-17
[PATCH 19/74] misc: don't leak file descriptors · Darrick J. Wong <hidden> · 2013-12-11
Re: [PATCH 19/74] misc: don't leak file descriptors · Theodore Ts'o <tytso@mit.edu> · 2013-12-12
[PATCH 20/74] mke2fs: don't leak memory · Darrick J. Wong <hidden> · 2013-12-11
Re: [PATCH 20/74] mke2fs: don't leak memory · Theodore Ts'o <tytso@mit.edu> · 2013-12-12
[PATCH 21/74] e4defrag: don't crash if umounts the filesystem races with us · Darrick J. Wong <hidden> · 2013-12-11
Re: [PATCH 21/74] e4defrag: don't crash if umounts the filesystem races with us · Theodore Ts'o <tytso@mit.edu> · 2013-12-12
[PATCH 22/74] e4defrag: defensively check results of sysconf(_SC_PAGESIZE) · Darrick J. Wong <hidden> · 2013-12-11
Re: [PATCH 22/74] e4defrag: defensively check results of sysconf(_SC_PAGESIZE) · Theodore Ts'o <tytso@mit.edu> · 2013-12-12
[PATCH 23/74] e2image: check return value from check_if_mounted · Darrick J. Wong <hidden> · 2013-12-11
Re: [PATCH 23/74] e2image: check return value from check_if_mounted · Theodore Ts'o <tytso@mit.edu> · 2013-12-12
[PATCH 24/74] dumpe2fs: check return values · Darrick J. Wong <hidden> · 2013-12-11
Re: [PATCH 24/74] dumpe2fs: check return values · Theodore Ts'o <tytso@mit.edu> · 2013-12-12
[PATCH 25/74] libss: fix fd error handling · Darrick J. Wong <hidden> · 2013-12-11
Re: [PATCH 25/74] libss: fix fd error handling · Theodore Ts'o <tytso@mit.edu> · 2013-12-12
[PATCH 26/74] libss: fix memory handling errors · Darrick J. Wong <hidden> · 2013-12-11
Re: [PATCH 26/74] libss: fix memory handling errors · Theodore Ts'o <tytso@mit.edu> · 2013-12-12
Re: [PATCH 26/74] libss: fix memory handling errors · Eric Sandeen <hidden> · 2013-12-17
Re: [PATCH 26/74] libss: fix memory handling errors · Darrick J. Wong <hidden> · 2013-12-18
[PATCH 27/74] libquota: fix memory leak · Darrick J. Wong <hidden> · 2013-12-11
Re: [PATCH 27/74] libquota: fix memory leak · Theodore Ts'o <tytso@mit.edu> · 2013-12-12
[PATCH 28/74] libext2fs: check return values · Darrick J. Wong <hidden> · 2013-12-11
Re: [PATCH 28/74] libext2fs: check return values · Theodore Ts'o <tytso@mit.edu> · 2013-12-12
Re: [PATCH 28/74] libext2fs: check return values · Eric Sandeen <hidden> · 2013-12-17
Re: [PATCH 28/74] libext2fs: check return values · Eric Sandeen <hidden> · 2013-12-17
[PATCH 29/74] libext2fs: fix memory leaks · Darrick J. Wong <hidden> · 2013-12-11
Re: [PATCH 29/74] libext2fs: fix memory leaks · Theodore Ts'o <tytso@mit.edu> · 2013-12-12
[PATCH 30/74] libext2fs: fix a broken close() test · Darrick J. Wong <hidden> · 2013-12-11
Re: [PATCH 30/74] libext2fs: fix a broken close() test · Theodore Ts'o <tytso@mit.edu> · 2013-12-12
[PATCH 31/74] libext2fs: fail fileio write if we can't allocate a block · Darrick J. Wong <hidden> · 2013-12-11
Re: [PATCH 31/74] libext2fs: fail fileio write if we can't allocate a block · Theodore Ts'o <tytso@mit.edu> · 2013-12-12
[PATCH 32/74] libext2fs: fix punching extents when there are no left extents · Darrick J. Wong <hidden> · 2013-12-11
Re: [PATCH 32/74] libext2fs: fix punching extents when there are no left extents · Theodore Ts'o <tytso@mit.edu> · 2013-12-12
[PATCH 33/74] libext2fs: don't error out when punching a totally sparse file · Darrick J. Wong <hidden> · 2013-12-11
Re: [PATCH 33/74] libext2fs: don't error out when punching a totally sparse file · Theodore Ts'o <tytso@mit.edu> · 2013-12-12
[PATCH 34/74] e2fsck: in rehash, mark newly allocated extent blocks as found · Darrick J. Wong <hidden> · 2013-12-11
Re: [PATCH 34/74] e2fsck: in rehash, mark newly allocated extent blocks as found · Theodore Ts'o <tytso@mit.edu> · 2013-12-12
[PATCH 35/74] libext2fs: zero block contents past EOF when setting size · Darrick J. Wong <hidden> · 2013-12-11
Re: [PATCH 35/74] libext2fs: zero block contents past EOF when setting size · Theodore Ts'o <tytso@mit.edu> · 2013-12-12
[PATCH 36/74] libext2fs: detect · Darrick J. Wong <hidden> · 2013-12-11
Re: [PATCH 36/74] libext2fs: detect · Theodore Ts'o <tytso@mit.edu> · 2013-12-13
Re: [PATCH 36/74] libext2fs: detect · Darrick J. Wong <hidden> · 2014-01-15
[PATCH 37/74] libext2fs: don't always read backup group descriptors on a 1k-block meta_bg fs · Darrick J. Wong <hidden> · 2013-12-11
Re: [PATCH 37/74] libext2fs: don't always read backup group descriptors on a 1k-block meta_bg fs · Theodore Ts'o <tytso@mit.edu> · 2014-01-11
[PATCH 38/74] libext2fs: mark group data blocks when loading block bitmap · Darrick J. Wong <hidden> · 2013-12-11
Re: [PATCH 38/74] libext2fs: mark group data blocks when loading block bitmap · Theodore Ts'o <tytso@mit.edu> · 2014-01-11
[PATCH 39/74] e2fsck: remove uninit block bitmap calculation · Darrick J. Wong <hidden> · 2013-12-11
Re: [PATCH 39/74] e2fsck: remove uninit block bitmap calculation · Theodore Ts'o <tytso@mit.edu> · 2014-01-11
[PATCH 40/74] libext2fs: no need to clear BLOCK_UNINIT during ext2fs_reserve_super_and_bgd · Darrick J. Wong <hidden> · 2013-12-11
RE: [PATCH 40/74] libext2fs: no need to clear BLOCK_UNINIT during ext2fs_reserve_super_and_bgd · Akira Fujita <hidden> · 2014-01-10
Re: [PATCH 40/74] libext2fs: no need to clear BLOCK_UNINIT during ext2fs_reserve_super_and_bgd · Theodore Ts'o <tytso@mit.edu> · 2014-01-11
[PATCH 41/74] tests: adjust test output to reflect block_uninit calculated block bitmaps · Darrick J. Wong <hidden> · 2013-12-11
Re: [PATCH 41/74] tests: adjust test output to reflect block_uninit calculated block bitmaps · Theodore Ts'o <tytso@mit.edu> · 2014-01-11
[PATCH 42/74] libext2fs: only punch complete clusters · Darrick J. Wong <hidden> · 2013-12-11
Re: [PATCH 42/74] libext2fs: only punch complete clusters · Theodore Ts'o <tytso@mit.edu> · 2013-12-16
[PATCH 43/74] libext2fs: don't update the summary counts when doing implied cluster allocation · Darrick J. Wong <hidden> · 2013-12-11
Re: [PATCH 43/74] libext2fs: don't update the summary counts when doing implied cluster allocation · Theodore Ts'o <tytso@mit.edu> · 2013-12-16
[PATCH 44/74] e2fsck: only release clusters when shortening a directory during a rehash · Darrick J. Wong <hidden> · 2013-12-11
Re: [PATCH 44/74] e2fsck: only release clusters when shortening a directory during a rehash · Theodore Ts'o <tytso@mit.edu> · 2013-12-16
[PATCH 45/74] e2fsck: print cluster ranges when encountering bitmap errors · Darrick J. Wong <hidden> · 2013-12-11
Re: [PATCH 45/74] e2fsck: print cluster ranges when encountering bitmap errors · Theodore Ts'o <tytso@mit.edu> · 2013-12-16
[PATCH 46/74] e2fsck: try implied cluster allocation when expanding a dir · Darrick J. Wong <hidden> · 2013-12-11
Re: [PATCH 46/74] e2fsck: try implied cluster allocation when expanding a dir · Theodore Ts'o <tytso@mit.edu> · 2013-12-16
[PATCH 47/74] resize2fs: during shrink, don't free in-use bg data clusters · Darrick J. Wong <hidden> · 2013-12-11
Re: [PATCH 47/74] resize2fs: during shrink, don't free in-use bg data clusters · Theodore Ts'o <tytso@mit.edu> · 2013-12-16
Re: [PATCH 47/74] resize2fs: during shrink, don't free in-use bg data clusters · Darrick J. Wong <hidden> · 2013-12-16
Re: [PATCH 47/74] resize2fs: during shrink, don't free in-use bg data clusters · Theodore Ts'o <tytso@mit.edu> · 2014-02-24
[PATCH 48/74] resize2fs: don't free in-use clusters when moving blocks · Darrick J. Wong <hidden> · 2013-12-11
Re: [PATCH 48/74] resize2fs: don't free in-use clusters when moving blocks · Theodore Ts'o <tytso@mit.edu> · 2014-02-24
[PATCH 49/74] mke2fs: set block_validity as a default mount option · Darrick J. Wong <hidden> · 2013-12-11
[PATCH 50/74] libext2fs: support allocating uninit blocks in bmap2() · Darrick J. Wong <hidden> · 2013-12-11
Re: [PATCH 50/74] libext2fs: support allocating uninit blocks in bmap2() · Theodore Ts'o <tytso@mit.edu> · 2014-01-11
Re: [PATCH 50/74] libext2fs: support allocating uninit blocks in bmap2() · Darrick J. Wong <hidden> · 2014-01-15
Re: [PATCH 50/74] libext2fs: support allocating uninit blocks in bmap2() · Theodore Ts'o <tytso@mit.edu> · 2014-01-15
Re: [PATCH 50/74] libext2fs: support allocating uninit blocks in bmap2() · Theodore Ts'o <tytso@mit.edu> · 2014-01-15
[PATCH 51/74] libext2fs: file IO routines should handle uninit blocks · Darrick J. Wong <hidden> · 2013-12-11
[PATCH 52/74] resize2fs: convert fs to and from 64bit mode · Darrick J. Wong <hidden> · 2013-12-11
[PATCH 53/74] resize2fs: when toggling 64bit, don't free in-use bg data clusters · Darrick J. Wong <hidden> · 2013-12-11
[PATCH 54/74] resize2fs: adjust reserved_gdt_blocks when changing group descriptor size · Darrick J. Wong <hidden> · 2013-12-11
[PATCH 55/74] libext2fs: support modifying arbitrary extended attributes · Darrick J. Wong <hidden> · 2013-12-11
Re: [PATCH 55/74] libext2fs: support modifying arbitrary extended attributes · Theodore Ts'o <tytso@mit.edu> · 2014-02-24
[PATCH 56/74] libext2fs: various tweaks to the xattr editor APIs · Darrick J. Wong <hidden> · 2013-12-11
Re: [PATCH 56/74] libext2fs: various tweaks to the xattr editor APIs · Theodore Ts'o <tytso@mit.edu> · 2014-02-24
[PATCH 57/74] libext2fs: extend xattr api to query number of attrs · Darrick J. Wong <hidden> · 2013-12-11
Re: [PATCH 57/74] libext2fs: extend xattr api to query number of attrs · Theodore Ts'o <tytso@mit.edu> · 2014-02-24
[PATCH 58/74] libext2fs: free key/value pairs before reading · Darrick J. Wong <hidden> · 2013-12-11
Re: [PATCH 58/74] libext2fs: free key/value pairs before reading · Theodore Ts'o <tytso@mit.edu> · 2014-02-24
[PATCH 59/74] debugfs: dump all extended attributes · Darrick J. Wong <hidden> · 2013-12-11
Re: [PATCH 59/74] debugfs: dump all extended attributes · Theodore Ts'o <tytso@mit.edu> · 2014-02-24
[PATCH 60/74] libext2fs: ensure that inline data is always written to ibody · Darrick J. Wong <hidden> · 2013-12-11
[PATCH 61/74] libext2fs: fix ext2fs_open2() truncation of the superblock parameter · Darrick J. Wong <hidden> · 2013-12-11
[PATCH 62/74] misc: add fuse2fs, a FUSE server for e2fsprogs · Darrick J. Wong <hidden> · 2013-12-11
[PATCH 63/74] fuse2fs: translate ACL structures · Darrick J. Wong <hidden> · 2013-12-11
[PATCH 64/74] Subject: [PATCH] fuse2fs: support allocating uninit blocks in fallocate · Darrick J. Wong <hidden> · 2013-12-11
[PATCH 65/74] fuse2fs: handle 64-bit dates correctly · Darrick J. Wong <hidden> · 2013-12-11
[PATCH 67/74] tests: check correct handling of reading and writing uninit extents · Darrick J. Wong <hidden> · 2013-12-11
[PATCH 68/74] tests: Add block_validity speed test · Darrick J. Wong <hidden> · 2013-12-11
[PATCH 69/74] Subject: [PATCH] tests: test what happens if we run out of space · Darrick J. Wong <hidden> · 2013-12-11
[PATCH 70/74] tests: add stale data after truncate test · Darrick J. Wong <hidden> · 2013-12-11
[PATCH 71/74] tests: check mapping of really high logical block offsets · Darrick J. Wong <hidden> · 2013-12-11
[PATCH 72/74] Subject: [PATCH] tests: enable using fuse2fs with metadata checksum test · Darrick J. Wong <hidden> · 2013-12-11
[PATCH 73/74] tests: add large symlink test · Darrick J. Wong <hidden> · 2013-12-11
[PATCH 74/74] tests: test date handling · Darrick J. Wong <hidden> · 2013-12-11

From: Theodore Ts'o <tytso@mit.edu>
Date: 2013-12-12 17:48:57

On Tue, Dec 10, 2013 at 05:19:41PM -0800, Darrick J. Wong wrote:

If we have to create a big symlink (i.e. one that doesn't fit into
i_block[]), we are not 64bit block safe and the namei code does not
handle extents at all.  Fix both.

Signed-off-by: Darrick J. Wong <redacted>

Thanks, applied.

					- Ted

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help