Thread (22 messages) 22 messages, 5 authors, 2013-08-28

Re: [PATCH 1/5] ext4: Error out if verifying the block bitmap fails

From: Theodore Ts'o <tytso@mit.edu>
Date: 2013-08-28 19:36:14

On Fri, Jul 19, 2013 at 04:55:39PM -0700, Darrick J. Wong wrote:
The block bitmap verification code assumes that calling ext4_error() either
panics the system or makes the fs readonly.  However, this is not always true:
when 'errors=continue' is specified, an error is printed but we don't return
any indication of error to the caller, which is (probably) the block allocator,
which pretends that the crud we read in off the disk is a usable bitmap.  Yuck.

A block bitmap that fails the check should at least return no bitmap to the
caller.  The block allocator should be told to go look in a different group,
but that's a separate issue.

The easiest way to reproduce this is to modify bg_block_bitmap (on a ^flex_bg
fs) to point to a block outside the block group; or you can create a
metadata_csum filesystem and zero out the block bitmaps.

Signed-off-by: Darrick J. Wong <redacted>
Thanks, applied.

					- Ted
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help