On Mon, Jun 24, 2013 at 10:37:57AM +0000, Sidorov, Andrei wrote:

On 24.06.2013 13:36, Namjae Jeon wrote:

quoted

Currently, we can try implementing dave's suggesstion of introducing a
new flag FALLOC_FL_COLLAPSE_RANGE for falloctae instead of individual
ioctls for both XFS and EXT4. Thanks.

Hi,

Currently PUNCH_HOLE requires KEEP_SIZE to be set as well. I think there
is no need to invent COLLAPSE_RANGE, but instead fallocate should
support PUNCH_HOLE without KEEP_SIZE. However I'm not sure that putting
block alignment restriction is a right way to go.

PUNCH_HOLE without KEEP_SIZE makes sense to me.

Regards,
                                                - Zheng