Thread (5 messages) 5 messages, 4 authors, 2013-05-28

Re: [PATCH v3] jbd2: Fix block tag checksum verification brokenness

From: Theodore Ts'o <tytso@mit.edu>
Date: 2013-05-28 11:34:30
Also in: linux-fsdevel

On Mon, May 13, 2013 at 02:47:50PM -0700, Darrick J. Wong wrote:
Al Viro complained of a ton of bogosity with regards to the jbd2 block tag
header checksum.  This one checksum is 16 bits, so cut off the upper 16 bits
and treat it as a 16-bit value and don't mess around with be32* conversions.
Fortunately metadata checksumming is still "experimental" and not in a shipping
e2fsprogs, so there should be few users affected by this.

v2: Eliminate unnecessary variables and make it clear(er) which values are 32
bits wide.

v3: Add a comment about why we're only storing half of the crc32c.

Reported-by: Al Viro <viro@ZenIV.linux.org.uk>
Signed-off-by: Darrick J. Wong <redacted>
Thanks, applied.

					- Ted
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help