Re: [PATCH RESEND] vfs: re-implement writeback_inodes_sb(_nr)_if_idle() and rename them
From: David Sterba <hidden>
Date: 2012-12-28 14:33:38
Also in:
linux-btrfs, linux-fsdevel
On Thu, Dec 20, 2012 at 06:09:35PM +0800, Miao Xie wrote:
quoted hunk ↗ jump to hunk
--- a/fs/fs-writeback.c +++ b/fs/fs-writeback.c@@ -1314,7 +1314,6 @@ void writeback_inodes_sb_nr(struct super_block *sb, bdi_queue_work(sb->s_bdi, &work); wait_for_completion(&done); } -EXPORT_SYMBOL(writeback_inodes_sb_nr);
Why do you remove the export? writeback_inodes_sb is exported as well. Originally the _nr variant has been introduced for btrfs (3259f8bed2f0f57c2fdcdac1b510c3fa319ef97e) and there are no other users now, so from that point it would make sense. From the other side, the change is not strictly necessary for this patch and keeps the writeback API a bit more flexible. I vote for keeping it. Otherwise (for the btrfs part), Tested-by: David Sterba <redacted> thanks, david