Re: [PATCH 4/4] block: Optionally snapshot page contents to provide stable pages during write
From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Date: 2012-12-27 19:14:49
Also in:
linux-fsdevel, lkml
"Darrick J. Wong" [off-list ref] writes:
quoted hunk
diff --git a/include/uapi/linux/fs.h b/include/uapi/linux/fs.h index 780d4c6..0144fbb 100644 --- a/include/uapi/linux/fs.h +++ b/include/uapi/linux/fs.h@@ -69,6 +69,7 @@ struct inodes_stat_t { #define MS_REMOUNT 32 /* Alter flags of a mounted FS */ #define MS_MANDLOCK 64 /* Allow mandatory locks on an FS */ #define MS_DIRSYNC 128 /* Directory modifications are synchronous */ +#define MS_SNAP_STABLE 256 /* Snapshot pages during writeback, if needed */ #define MS_NOATIME 1024 /* Do not update access times. */ #define MS_NODIRATIME 2048 /* Do not update directory access times */ #define MS_BIND 4096
I think this flag should be separated into "FS provide stable page" and "FS needs bounce buffer for stable page". My fs (I guess btrfs also) provides stable page by better way, and doesn't need to wait writeback flags too. What needs is just to avoid those stable page stuff. Thanks. -- OGAWA Hirofumi [off-list ref]