On 12/04/2012 09:40 PM, Tao Ma wrote:

Hi Ted,
On 12/04/2012 09:27 PM, Theodore Ts'o wrote:

quoted

On Tue, Dec 04, 2012 at 10:29:00AM +0100, Jiri Slaby wrote:

quoted

Hi,

commit a7b0168d4a9bb78535827ddaf9c055963f5bd7aa
Author: Tao Ma [off-list ref]
Date:   Sun Dec 2 20:30:52 2012 -0500

    ext4: let fallocate handle inline data correctly

added

static int int ext4_convert_inline_data(struct inode *inode)

       ^^^^^^^

when EXT4_FS_XATTR is unset.

Care to fix that?

Oops.  Thanks for catching this!!!

Please push the patch with the subject "[PATCH] ext4: Fix inline data
build warning found by kernel build testing." and these error should go
away. And also Dan's smatch has found another issue and I have sent out
the patch with subject "[PATCH] ext4: Fix inline data build warning
found by kernel build testing.".

sorry, I hit the send button too fast. The subject for the 2nd patch is
"[PATCH] ext4: Fix a build warning in __ext4_journalled_writepage."
Sorry for all the trouble.

Thanks
Tao