On Thu 01-11-12 10:24:48, Boaz Harrosh wrote:

On 11/01/2012 01:59 AM, Jan Kara wrote:
<>

quoted

(all block device inodes share one superblock).

Really? that is not so good is it, for other obvious reasons. 
Why is it not one superblock per BDI? That would be more obvious
to me.

quoted

Thoughts?

It's a really bad design. I think it is worth fixing. For the above
problem, as well as a much better fit with our current thread-per-bdi,
and the rest of the Kernel model. No?

  So the fact that there is one superblock of virtual filesystem containing
all block device inodes is inconvenient at times (that's why we have to
have inode_to_bdi() function in fs/fs-writeback.c) but OTOH you cannot
really attach these virtual block device inodes (note that these are
different from an inode for an object say /dev/sda in the filesystem)
anywhere else and having one sb per block device would really be an
overkill.

								Honza
-- 
Jan Kara [off-list ref]
SUSE Labs, CR