On Thu, Oct 11, 2012 at 10:35:28PM +0800, Zhi Yong Wu wrote:

quoted

quoted

--- a/fs/btrfs/super.c
+++ b/fs/btrfs/super.c

@@ -303,7 +304,7 @@ enum {
      Opt_notreelog, Opt_ratio, Opt_flushoncommit, Opt_discard,
      Opt_space_cache, Opt_clear_cache, Opt_user_subvol_rm_allowed,
      Opt_enospc_debug, Opt_subvolrootid, Opt_defrag, Opt_inode_cache,
-     Opt_no_space_cache, Opt_recovery, Opt_skip_balance,
+     Opt_no_space_cache, Opt_recovery, Opt_skip_balance, Opt_hot_track,

Please add the new option to the end.

To be honest, it can't be added to the end, if you check Opt_err's
pattern value, you will find it is NULL, it will cause match_one()
return 1. So if we add Opt_hot_track to the end of this array, it will
be covered by match_token(), so i prefer to add it to
Opt_fatal_errors. Do you think of it?

Ah, sorry, I was not clear what the 'end' means here. The Opt_err is a
end-of-the-list token, so yes please add hot_track between
Opt_fatal_errors and Opt_err.

david