Thread (7 messages) 7 messages, 3 authors, 2012-11-08

Re: [PATCH 2/2] ext4: Warn when discard request fails other than EOPNOTSUPP

From: Carlos Maiolino <hidden>
Date: 2012-10-23 13:15:07

On Fri, Oct 19, 2012 at 02:12:38PM +0200, Lukas Czerner wrote:
We should warn user then the discard request fails. However we need to
exclude -EOPNOTSUPP case since parts of the device might not support it
while other parts can. So print the kernel warning when the error !=
-EOPNOTSUPP is returned from ext4_issue_discard().

We should also handle error cases in batched discard, again excluding
EOPNOTSUPP.

Signed-off-by: Lukas Czerner <redacted>
---
 fs/ext4/mballoc.c |   47 +++++++++++++++++++++++++++++++++++------------
 1 files changed, 35 insertions(+), 12 deletions(-)
Looks good

Reviewed-by: Carlos Maiolino <redacted>
-- 
--Carlos
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help