Re: Test 272 fails for ext3

On Tue, Aug 21, 2012 at 10:03:39AM +0200, Jan Kara wrote:

On Tue 21-08-12 08:49:41, Dave Chinner wrote:

quoted

On Mon, Aug 20, 2012 at 11:06:38PM +0200, Jan Kara wrote:
....

quoted

--- a/272
+++ b/272

@@ -32,15 +32,18 @@ tmp=/tmp/$$
 status=1	# failure is the default!
 trap "rm -f $tmp.*; exit \$status" 0 1 2 3 15
 
+write_opt_list="iflag=noatime conv=notrunc conv=fsync oflag=direct"
+if [ $FSTYP = "ext3" ]; then
+	# ext3 doesn't support direct IO in journalling mode
+	write_opt_list="iflag=noatime conv=notrunc conv=fsync"
+fi

Seems like asking for trouble duplicating the common options.

# ext3 doesn't support direct IO in journalling mode
write_opt_list="iflag=noatime conv=notrunc conv=fsync
[ $FSTYP = "ext4" ] && write_opt_list="$write_opt_list oflag=direct"

Otherwise looks fine.

Reviewed-by: Dave Chinner <redacted>

  OK, I've updated the test as you suggested. Result is attached.

Committed to git://oss.sgi.com/xfs/cmds/xfstests.git, master branch.