On 9/12/12 9:04 PM, Brad Figg wrote:

On 09/12/2012 06:51 PM, Eric Sandeen wrote:

quoted

On 9/12/12 7:41 PM, Brad Figg wrote:

quoted

Eric,

Thanks for taking the time to point this out. We will adjust our testing accordingly.
We initially tried to run xfstest against ext2, ext3, ext4, xfs and btrfs. We are also
trying to get these tests to run on several different kernel versions as you can
see from our test results. We were running into issues on different kernels and various
file-systems while getting our act together, we did this as a band-aid.

I see.

quoted

I accept that we have some things to learn w.r.t. running this test suite. We will work
to run the xfstests "as is" without any outside "intelligence". We do recognise that
is a dynamic set of tests that people are adding to regularly.

I am not attempting to get just a series of "pass" results. If that were my goal
I could accomplish it much easier and would not have engaged with the community
on the mailing list. We want to help where we can and will accept constructive
criticism.

Sorry, it sounds like I came across too strong there - it was just a little worrying to see failing or problematic tests disabled or otherwise artificially restricted.

I'm actually very excited to see you setting up ongoing, public testing using xfstests, I think it'll be a great benefit, especially if there's a way to see a particular test's results across several kernel versions and/or filesystems and/or architectures, so that patterns of failure can emerge.

If you find that xfstests is missing some feature or behavior which would facilitate testing in the automated environment, please do let us know what you need - or send patches.  :)

Thanks,
-Eric

quoted

Brad

No harm, no foul. We really don't mind constructive criticism. We are also
eager to get this setup and running. We will try to contribute more than
just running tests.

Just running them and publishing results is definitely useful.

I do want to point out that we are using the xfstests which is a snapshot
in autotest. We do also look at the latest xfstests in the official xfstests
repo and add it in when we see a delta. We will also work with the autotest
maintainers to stay more up-to-date with xfstests.

Ah, I didn't know that autotest had a snapshot.  I wonder if there's a way to
tease that back out, and pull down xfstests from git daily.

FWIW, it's a little confusing - we have 2 repos:

git://oss.sgi.com/xfs/cmds/xfstests.git
git://git.kernel.org/pub/scm/fs/xfs/xfstests-dev.git

the one on kernel.org is where most rapid development seems to happen, and changes get pulled over to sgi.  Sometimes, it goes the other way.

Did autotest make any changes to what's upstream?

-Eric

Thanks,
Brad

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs