Re: [PATCH 07/11] ext4: serialize unlocked dio reads with truncate

On Sat, 29 Sep 2012 00:49:04 -0400, "Theodore Ts'o" [off-list ref] wrote:

On Fri, Sep 28, 2012 at 07:44:07PM +0400, Dmitry Monakhov wrote:

quoted

 	if (attr->ia_valid & ATTR_SIZE) {
-		if (attr->ia_size != i_size_read(inode))
+		if (attr->ia_size != inode->i_size) {

Why this change?   Why are you not using i_size_read() here?

Since we hold i_mutex no one is able to change i_size, and it
is safe to access it directly.

    	 	       	       	   - Ted