Thread (6 messages) 6 messages, 3 authors, 2012-08-18

Re: [PATCH 3/8] ext3: remove lock/unlock super

From: Marco Stornelli <hidden>
Date: 2012-08-17 06:47:04
Also in: linux-fsdevel, lkml

Il 16/08/2012 21:19, Theodore Ts'o ha scritto:
On Thu, Aug 16, 2012 at 06:39:04PM +0200, Jan Kara wrote:
quoted
On Thu 16-08-12 12:00:26, Marco Stornelli wrote:
quoted
From: Marco Stornelli <redacted>

Replaced lock and unlock super with a new fs mutex s_lock.
   Hum, is the lock needed at all? Remount & unfreeze both run with s_umount
held for writing. Thus we already have exclusion between these two calls.
The same seems to hold for ext4 BTW.
Agreed, it's not clear lock_super() is needed at all for ext4 at this
point.

	     	       		       	      - Ted
Great. I'll remove the calls for ext3/ext4 when I'll submit the second 
version of the patch.

Thanks for your feedback,

Marco
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help