Re: [PATCHv6 3/5] ext4: remove unnecessary superblock dirtying

On Wed, 2012-07-11 at 12:11 +0200, Jan Kara wrote:

quoted

quoted

So case 2.b is a bit controversial, but I think it is acceptable. After all, by
enabling checksumming we already sign up for paying the price of calculating
it. The way to improve checksumming performance globally would be to calculate
it just before sending buffers to the I/O queue. We'd need some kind of
call-back which could be registered by file-systems.

  Actually, the most common case of adding orphan inode used
ext4_handle_dirty_super_now() so for that case there is no difference. And
other cases are so rare it really does not matter... So there shouldn't be
any measurable difference.

Thank you, I'll take a closer look and possibly change the commit
message.

-- 
Best Regards,
Artem Bityutskiy