On Mon, Jul 30, 2012 at 5:01 PM, Lukáš Czerner [off-list ref] wrote:

On Sun, 29 Jul 2012, Namjae Jeon wrote:

quoted

Date: Sun, 29 Jul 2012 07:31:54 -0400
From: Namjae Jeon <redacted>
To: tytso@mit.edu, sandeen@redhat.com, lczerner@redhat.com,
    linux-ext4@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Namjae Jeon <redacted>,
    Amit Sahrawat [off-list ref]
Subject: [PATCH] ext4: add error handling when discard cmd is fail in FITRIM

Although free extents is proper not trimmed(mmc driver return error code
while sending trim command), currently FITRIM ioctl return success.
Add exception routine to inform user error code.

#> ./fitrim_test
end_request: I/O error, dev mmcblk0, sector 27232
EXT4-fs warning (device mmcblk0): ext4_trim_all_free:4857:
Discard command returned error -5
#>

Well, by this change you're actually reverting commit

d9f34504e6952e909a6932c5b2d1857716606380
         ext4: ignore errors when issuing discards

which effectively reverts a30eec2a8.

Now I think that the way it is now is actually better than your
proposal for the reasons mentioned in the commit
d9f34504e6952e909a6932c5b2d1857716606380. However I think that the

How about instead of propagating the error to user and breaking out of
the discard, just print a warning message like:
ext4_warning(sb, "error %d while trimming group block from %d to
%d\n",ret, start, next);

discard errors should be logged nevertheless but not at the file
system level, but rather on block layer level if it is not done
already.

Thanks!
-Lukas

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html