Thread (3 messages) 3 messages, 3 authors, 2012-07-09

Re: [PATCH] ext4: Use proper csum calculation in ext4_rename.

From: Theodore Ts'o <tytso@mit.edu>
Date: 2012-07-09 14:07:59

On Tue, Jul 03, 2012 at 10:01:53AM -0700, Darrick J. Wong wrote:
On Fri, Jun 22, 2012 at 11:38:34PM +0800, Tao Ma wrote:
quoted
From: Tao Ma <redacted>

In ext4_rename, when the old name is a dir, we need to
change ".." to its new parent and journal the change, so
with metadata_csum enabled, we have to re-calc the csum.

As the first block of the dir can be either a htree root
or a normal directory block and we have different csum
calculation for these 2 types, we have to choose the right
one in ext4_rename.

btw, it is found by xfstests 013.
Good catch!

Acked-by: Darrick J. Wong <redacted>
Thanks, applied.

						- Ted
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help