Re: [PATCH 5/5] XFS: prjquota and grpqouta now may coexist
From: Dave Chinner <david@fromorbit.com>
Date: 2012-06-22 02:36:17
Also in:
linux-fsdevel
On Thu, Jun 21, 2012 at 01:08:53PM +0400, Dmitry Monakhov wrote:
quoted hunk ↗ jump to hunk
Signed-off-by: Dmitry Monakhov <redacted> --- fs/xfs/xfs_super.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c index 0d9de41..f408a27 100644 --- a/fs/xfs/xfs_super.c +++ b/fs/xfs/xfs_super.c@@ -538,14 +538,14 @@ xfs_showargs( else if (mp->m_qflags & XFS_UQUOTA_ACCT) seq_puts(m, "," MNTOPT_UQUOTANOENF); - /* Either project or group quotas can be active, not both */ - if (mp->m_qflags & XFS_PQUOTA_ACCT) { if (mp->m_qflags & XFS_OQUOTA_ENFD) seq_puts(m, "," MNTOPT_PRJQUOTA); else seq_puts(m, "," MNTOPT_PQUOTANOENF); - } else if (mp->m_qflags & XFS_GQUOTA_ACCT) { + } + + if (mp->m_qflags & XFS_GQUOTA_ACCT) { if (mp->m_qflags & XFS_OQUOTA_ENFD) seq_puts(m, "," MNTOPT_GRPQUOTA); else
Why can they co-exist now? XFS does not use the VFS quota code, and you've made no other changes to XFS so I can't see how you can make that assertion. There's a current patchset under review that allows XFS to have co-existing group and project quotas - it's complex, changes the on-disk format and requires userspace tool support (e.g. mkfs, repair, xfs_db, etc). So I can't see how this works with XFS at all... Cheers, Dave. -- Dave Chinner david@fromorbit.com