On 5/22/12 11:11 AM, Eric Sandeen wrote:

On 5/21/12 6:31 PM, Ted Ts'o wrote:

quoted

On Mon, May 21, 2012 at 03:22:28PM -0700, Linus Torvalds wrote:

quoted

So I'm pretty sure this patch is what we want, and rw_verify_area()
really is required to protect low-level filesystems from these kinds
of issues. Not just ext4.

At the same time, I would *really* want somebody who actually uses
anything AIO to test it out too. Because I want to not only commit it,
but also mark it for stable - and it would be nice to have some more
testing than me saying "ok, it passes the one test-case sent to me"
and "hey, the code looks sane".

Just FWIW, the ext4_file_write() part of this fix was sent by Zheng Liu on 4/12/12:

[PATCH RESEND] ext4: change return value from int to ssize_t in ext4_file_write

Sorry, I was talking about Manish's original patch, not Linus's followup.

-Eric

I'll see about writing an xfstest for this stuff too so it doesn't regress again.

-Eric