Thread (5 messages) 5 messages, 2 authors, 2012-05-29

Re: [PATCH] tests: use make rules to run tests in parallel (v3)

From: Ted Ts'o <tytso@mit.edu>
Date: 2012-05-29 12:33:53

On Tue, May 29, 2012 at 01:02:11AM -0600, Andreas Dilger wrote:
Hrm, one reason I made the generated files read-only is to avoid
accidentally editing the generated copy, and then losing the resulting
changes when the file is recreated (as happened several times with the
test_script file, when rebasing the patch).  I'd prefer to mark the
generated files read-only, and then have the Makefile rules delete the
file before recreating it.
I tend to just edit the foo.in file; the Makefile dependencies
automatically take care of rebuiling the test_one and test_script
files --- and it's much easier just to type "make" to retry the
generated scripts....
That avoids accidentally having developers edit the file, while allowing
the always-remembering Makefile rule to recreate the file without errors.
Yeah, but I don't want to encourage developers editing generated
files...  it's much better to make things much more convenient for
them to do things in the "right" way.  In the long run that's much
more effective at avoiding lost work, and it saves you effort (since
otherwise you might forget to fix the foo.in file before you commit
the change, etc.)

						- Ted
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help