Re: [PATCH RESEND] ext4: change return value from int to ssize_t in ext4_file_write

On Fri, Apr 13, 2012 at 09:22:37AM +0800, Zheng Liu wrote:

On 64-platform, when we do a write operation with a huge number of data, it
will cause that the ret variable overflows.  So it is replaced with ssize_t.

Reported-by: Jouni Siren <redacted>
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Zheng Liu <redacted>

Applied, with the following commit description:

   ext4: use consistent ssize_t type in ext4_file_write()

   The generic_file_aio_write() function returns ssize_t, and
   ext4_file_write() returns a ssize_t, so use a ssize_t to collect the
   return value from generic_file_aio_write().  It shouldn't matter since
   the VFS read/write paths shouldn't allow a read greater than MAX_INT,
   but there was previously a bug in the AIO code paths, and it's best if
   we use a consistent type so that the return value from
   generic_file_aio_write() can't get truncated.

Regards,

					- Ted