Thread (4 messages) flat view 4 messages, 3 authors, 2012-03-22

Re: [PATCH v2] REQ_META set during meta data write

From: Christoph Hellwig <hch@infradead.org>
Date: 2012-03-03 09:34:41
Also in: linux-fsdevel

On Fri, Mar 02, 2012 at 06:15:09PM +0530, Saugata Das wrote:
quoted hunk ↗ jump to hunk
--- a/fs/buffer.c
+++ b/fs/buffer.c
@@ -2926,6 +2926,9 @@ int submit_bh(int rw, struct buffer_head * bh)
 	if (test_set_buffer_req(bh) && (rw & WRITE))
 		clear_buffer_write_io_error(bh);
 
+	if (buffer_meta(bh))
+		rw |= REQ_META;
+
submit_bh has a perfectly valid rw argument where you can pass REQ_META.
Please use that instead of abusing a buffer state bit for an I/O
submission flag.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help